Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Thread Naming - Prioritization Fee Cache #30890

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

apfitzge
Copy link
Contributor

Problem

In #27237 @mvines has tried to standardize solana-controlled thread names. This thread was introduced around the same time, and so it has snuck through.

Summary of Changes

Shorten thread name to 15 characters.

Fixes #

@apfitzge apfitzge marked this pull request as ready for review March 24, 2023 17:04
@apfitzge apfitzge requested a review from tao-stones March 24, 2023 17:04
@apfitzge
Copy link
Contributor Author

@taozhu-chicago sorry for nitting this old thread name haha. Feel free to suggest a different (<=15 character) name 😄

Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works! thanks for making the change

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #30890 (78481a2) into master (5a05e9b) will decrease coverage by 0.1%.
The diff coverage is 60.0%.

@@            Coverage Diff            @@
##           master   #30890     +/-   ##
=========================================
- Coverage    81.5%    81.5%   -0.1%     
=========================================
  Files         726      726             
  Lines      204809   204914    +105     
=========================================
+ Hits       167027   167055     +28     
- Misses      37782    37859     +77     

@apfitzge apfitzge merged commit 2a05b25 into solana-labs:master Mar 24, 2023
@apfitzge apfitzge deleted the clean_up/thread_name branch March 24, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants